Fix BitcoinTx vsize calculation
#289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…include size for worst-case witness signatures
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #289 +/- ##
===========================================
+ Coverage 36.90% 36.94% +0.04%
===========================================
Files 25 25
Lines 9448 9454 +6
===========================================
+ Hits 3487 3493 +6
Misses 5961 5961 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
BitcoinTxvsize estimates to include size for worst-case witness signatures. This fixes the fee calculation for recovery transactions to ensure they properly pay a large enough fee."Worst-case" is based on including 100% of possible signatures, since it is possible for griefers to relay transactions with this many signatures regardless of how many are necessary to satisfy the threshold. If we can ensure it doesn't cause fee-rate-based Bitcoin confirmation DoS or delays, we can adjust this to a less conservative worst-case which is the maximum number of signatures to satisfy the threshold.